0 users online. Create an account or sign in to join them.Users

Announcement

Symphony's issue tracker has been moved to Github.

Issues are displayed here for reference only and cannot be created or edited.

Browse

Closed#119: Remove DS filtering re-orderability

No need for reordering of filters in a DS. the order does not change the results. This was mentioned by Nick here: http://github.com/symphony/symphony-2/issues/closed/#issue/71

Bah Github is playing silly buggers and I can’t commit my change. This can be fixed by changing the following:

Line 127 from this:

$('.orderable tr, .subsection > ol > li').live('mousedown', function(e) {

To this:

$('.orderable tr, .orderable li').live('mousedown', function(e) {

The only two places where this re-ordering UI pattern is used are the Section fields builder and the DS filter builder. Both have a “subsection” class, but only Section has an “orderable” class, therefore it makes sense for the ordering functionality to be applied to the “.orderable” components only. This was probably the intention anyway, but the selector was an oversight.

Pull requested

http://github.com/nickdunn/symphony-2/commit/5c803788f8efc28063d2b391b11d6677682956ad

Done

Alas, all of this is going to be negated by Rowan’s “duplicator” JavaScript anyway.

This issue is closed.

Symphony • Open Source XSLT CMS

Server Requirements

  • PHP 5.3-5.6 or 7.0-7.3
  • PHP's LibXML module, with the XSLT extension enabled (--with-xsl)
  • MySQL 5.5 or above
  • An Apache or Litespeed webserver
  • Apache's mod_rewrite module or equivalent

Compatible Hosts

Sign in

Login details