Remove DS filtering re-orderability
A for , submitted by Alistair on 24 August 2009
Announcement
Symphony's issue tracker has been moved to Github.
Issues are displayed here for reference only and cannot be created or edited.
Browse
Closed#119: Remove DS filtering re-orderability
-
-
- Alistair
- Comment #1
- 24 Aug 09, 2:39 pm
-
-
- nickdunn
- Comment #2
- 30 Aug 09, 8:39 am
Bah Github is playing silly buggers and I can’t commit my change. This can be fixed by changing the following:
Line 127 from this:
$('.orderable tr, .subsection > ol > li').live('mousedown', function(e) {
To this:
$('.orderable tr, .orderable li').live('mousedown', function(e) {
The only two places where this re-ordering UI pattern is used are the Section fields builder and the DS filter builder. Both have a “subsection” class, but only Section has an “orderable” class, therefore it makes sense for the ordering functionality to be applied to the “.orderable” components only. This was probably the intention anyway, but the selector was an oversight.
-
-
- nickdunn
- Comment #3
- 02 Sep 09, 3:30 pm
Pull requested
http://github.com/nickdunn/symphony-2/commit/5c803788f8efc28063d2b391b11d6677682956ad
-
-
- Alistair
- Comment #4
- 06 Sep 09, 4:54 pm
Done
-
-
- nickdunn
- Comment #5
- 06 Sep 09, 11:49 pm
Alas, all of this is going to be negated by Rowan’s “duplicator” JavaScript anyway.
This issue is closed.
No need for reordering of filters in a DS. the order does not change the results. This was mentioned by Nick here: http://github.com/symphony/symphony-2/issues/closed/#issue/71