0 users online. Create an account or sign in to join them.Users

Announcement

Symphony's issue tracker has been moved to Github.

Issues are displayed here for reference only and cannot be created or edited.

Browse

Closed#130: initialiseDatabase() uses inexistent configuration options

The initialiseDatabase function in class.symphony.php tries to read the value of force_query_caching (values: on/off) from the config file. But the latter does not contain this param. (Instead it includes disable_query_caching (values: yes/no), which might be a relict.)

Ill need to think about this. There are actually 3 possible outcomes with regards to the config settings.

  1. Nothing in the config. This just leaves the server to default to whatever it wants.
  2. Explicitly turning ON caching. This adds SQL_CACHE to all SELECT statements
  3. Explicitly turning OFF caching which adds SQL_NO_CACHE

The question is, what label best conveys this. force_query_caching set to “no” does not really imply that SQL_NO_CACHE will be added, ignoring the server default. Likewise disable_query_caching set to “no” does not imply SQL_CACHE.

Is there a better way to describe this behaviour?

So it has three possible values:

  • 'sql_query_caching' => 'default'
  • 'sql_query_caching' => 'on'
  • 'sql_query_caching' => 'off'

sql_query_caching sounds like a plan. However, I might just call it query_caching instead.

Consolidated ‘disable_query_caching’ and ‘force_query_caching’ database configuration settings into a single setting called ‘query_caching’. Accepts ‘yes’, ‘no’ or ‘default’ as values. Missing or NULL value assumes ‘default’. Closed by 709d0279018098c082ff5aad707c90427012c7cb

This issue is closed.

Symphony • Open Source XSLT CMS

Server Requirements

  • PHP 5.3-5.6 or 7.0-7.1
  • PHP's LibXML module, with the XSLT extension enabled (--with-xsl)
  • MySQL 5.5 or above
  • An Apache or Litespeed webserver
  • Apache's mod_rewrite module or equivalent

Compatible Hosts

Sign in

Login details