initialiseDatabase() uses inexistent configuration options
A for , submitted by michael-e on 16 September 2009
Announcement
Symphony's issue tracker has been moved to Github.
Issues are displayed here for reference only and cannot be created or edited.
Browse
Closed#130: initialiseDatabase() uses inexistent configuration options
-
-
- michael-e
- Comment #1
- 16 Sep 09, 1:44 am
-
-
- Alistair
- Comment #2
- 04 Oct 09, 10:24 pm
Ill need to think about this. There are actually 3 possible outcomes with regards to the config settings.
- Nothing in the config. This just leaves the server to default to whatever it wants.
- Explicitly turning ON caching. This adds
SQL_CACHEto allSELECTstatements - Explicitly turning OFF caching which adds
SQL_NO_CACHE
The question is, what label best conveys this. force_query_caching set to “no” does not really imply that SQL_NO_CACHE will be added, ignoring the server default. Likewise disable_query_caching set to “no” does not imply SQL_CACHE.
Is there a better way to describe this behaviour?
-
-
- michael-e
- Comment #3
- 05 Oct 09, 10:19 am
So it has three possible values:
'sql_query_caching' => 'default''sql_query_caching' => 'on''sql_query_caching' => 'off'
-
-
- Alistair
- Comment #4
- 05 Oct 09, 5:44 pm
sql_query_caching sounds like a plan. However, I might just call it query_caching instead.
-
-
- Alistair
- Comment #5
- 11 Oct 09, 10:04 pm
Consolidated ‘disable_query_caching’ and ‘force_query_caching’ database configuration settings into a single setting called ‘query_caching’. Accepts ‘yes’, ‘no’ or ‘default’ as values. Missing or NULL value assumes ‘default’. Closed by 709d0279018098c082ff5aad707c90427012c7cb
This issue is closed.
The
initialiseDatabasefunction inclass.symphony.phptries to read the value offorce_query_caching(values: on/off) from the config file. But the latter does not contain this param. (Instead it includesdisable_query_caching(values: yes/no), which might be a relict.)