DS editor cannot find DS dependencies in filter strings when does not start with $ds-
A for , submitted by Alistair on 14 October 2009
Announcement
Symphony's issue tracker has been moved to Github.
Issues are displayed here for reference only and cannot be created or edited.
Browse
Closed#145: DS editor cannot find DS dependencies in filter strings when does not start with $ds-
-
-
- Alistair
- Comment #1
- 14 Oct 09, 1:22 pm
-
-
- Alistair
- Comment #2
- 13 Oct 09, 8:23 pm
Fixed code resonsible for finding DS dependencies in filter strings. Closed by 6fa794d251d72396ed45d2596f20943a5f54c8e0
-
-
- nickdunn
- Comment #3
- 13 Oct 09, 11:35 pm
Am I right in saying this still requires at least one dependency to contain $ds-... for this to trigger? In the past I was come across an issue such that dependencies only work when they match ($ds- plus dsParamROOTELEMENT). If a (custom) DS outputs a parameter that is different from this format (e.g. my Articles DS has been customised to also output a param named “articles-author-ids” or even “ds-articles-author-ids”, other Data Sources will not correctly use this as a dependency because it does not match the root element name of my original Articles DS.
Is this the same or a related issue?
-
-
- Alistair
- Comment #4
- 13 Oct 09, 11:47 pm
It’s a related issue, but a limitation rather than a bug. This fix was specifically to correct bad regex. I have attempted to address the problem you mention, but so far haven’t had time to iron out all the kinks.
This issue is closed.
When a DS is saved, each filter string is checked for references to other data sources by matching
{$ds-*. This will not match references in a string such as{$id:$ds-blah}. Need to fix the regular expression.