Symphony.

In class.general.php the function rmdirr cannot possibly work as it references $f which is never declared.

It would be nice to rewrite the function to make use of deleteFile so that it can be used in extensions etc.

I’ve used this one in the past: function deleteDirectory($dir) { if (!file_exists($dir)) return true; if (!is_dir($dir)) return unlink($dir);

        foreach (scandir($dir) as $item) {
            if ($item == '.' || $item == '..') continue;
            if (!$this->deleteDirectory($dir.DIRECTORY_SEPARATOR.$item)) return false;
        }
        return rmdir($dir);
    }

Which I guess could be rewritten as the following to make use of deleteFile

    function rmdirr($dir) {
        if (!file_exists($dir)) return true;
        if (!is_dir($dir)) return $this->deleteFile($dir);

        foreach (scandir($dir) as $item) {
            if ($item == '.' || $item == '..') continue;
            if (!$this->rmdirr($dir.DIRECTORY_SEPARATOR.$item)) return false;
        }
        return rmdir($dir);
    }

heh. well spotted. Interestingly, General::rmdirr() is not used anywhere in Symphony’s core. I would suggest we remove it.

One more mystery was revealed. The smiley face already has gone! :P