0 users online. Create an account or sign in to join them.Users

Announcement

Symphony's issue tracker has been moved to Github.

Issues are displayed here for reference only and cannot be created or edited.

Browse

Closed#157: Dynamic XML DS timeout should be configurable

Currently it is hardcoded as 6 seconds. Either the DS editor needs to have field for setting timeout, or there needs to be a config setting in /manifest/config.php

Vote 1 for a per-DS setting.

Per-DS. But I don’t think it should be visible in the UI, it’s so rare that it needs to be re-configured. So I vote for a member of the DS object that can be customised per-DS for advanced users?

That works for me, though if it can’t be changed through the UI, would still be nice to see what the timeout period is.

Not sure that showing the timeout in the DS editor gives the user much meaningful information. Perhaps the timeout value should be visible in the XML?

<my-ds timeout="6">
    <error>No results found</error>
</my-ds>

If a DS is not working as intended, the first place you’d look is the page XML right? So, perhaps you’d see the timeout value and realise that could be the cause. Just a thought.

Works for me.

If I understand this correctly, this will always be present in data sources? For me this sound like the data source timed out after 6 seconds and that something is wrong - surely not what you like the user to think if it’s a value that is always present … Normally timeouts are nothing I have to care about as a normal Symphony user.

If a DS is not working as intended, the first place you’d look is the page XML right? So, perhaps you’d see the timeout value and realise that could be the cause. Just a thought.

It’s good for debugging but If nothing goes wrong It doesn’t make sense showing that attribute. I also don’t think an attribute will be the right choice. What about a reason node describing that error?

Normally timeouts are nothing I have to care about as a normal Symphony user.

Agree.

If I understand this correctly, this will always be present in data sources?

No. Doesn’t make a whole lot of sense to show it unless there is a problem.

That XML I wrote above was really a stupid example. I don’t think an actual attribute called “timeout” is sensible. Next time I won’t be as lazy. ;)

What I was actually thinking was something like

<my-ds ... >
    <error>Request timed out. X second limit reached.</error>
</my-ds>

But I don’t think it should be visible in the UI, it’s so rare that it needs to be re-configured.

Yup. Agree with you on that. I had ideas of introducing a new constant to the Dynamic DS. Something like public $dsParamREQUEST_TIMEOUT = 6. The value can be automatically retained by the DS editor when editing.

This issue is closed.

Symphony • Open Source XSLT CMS

Server Requirements

  • PHP 5.3-5.6 or 7.0-7.1
  • PHP's LibXML module, with the XSLT extension enabled (--with-xsl)
  • MySQL 5.5 or above
  • An Apache or Litespeed webserver
  • Apache's mod_rewrite module or equivalent

Compatible Hosts

Sign in

Login details