Robustness of getPostData()
A for , submitted by phoque on 11 February 2010
Announcement
Symphony's issue tracker has been moved to Github.
Issues are displayed here for reference only and cannot be created or edited.
Browse
Closed#228: Robustness of getPostData()
-
-
- phoque
- Comment #1
- 11 Feb 10, 6:21 pm
-
-
- Alistair
- Comment #2
- 19 Mar 10, 6:48 pm
We have improved the robustness of this function. http://github.com/symphony/symphony-2/commit/931823f26d6d018d6cffc8d770969720a00f909a
This issue is closed.
While playing around with EventEx and Symphony 2.0.7RC1 I managed to break getPostData() a quite often and quite easily. Although this may certainly a bug in ADSC, DatabaseManipulator or EventEx it shows that getPostData() isn’t very robust.
If the argument of one of the two foreach-loops is malformed, a fatal error is thrown, stopping any other executions. In my eyes this should be prevented and a much more frugal behaviour should be aimed for, i.e. ignoring invalid data, skipping the loops altogether and reporting an error back to the event.