0 users online. Create an account or sign in to join them.Users
A suggestion for 2.2.1, submitted by brendo on 10 June 2011
Symphony's issue tracker has been moved to Github.
Issues are displayed here for reference only and cannot be created or edited.
Currently when Events and Datasources are saved, a version parameter is saved, which at the moment is always 1.0. I have no idea the origins of why this was introduced, but I'm wondering whether it would be useful to save the version of Symphony that generated the datasource.
This may be used in the future in update.php for changes that affect datasources/events in that it might be able to load and make the changes to the datasources without a user having to resave them.
Thoughts? Is anyone using the version of these events for anything internal?
Yeah I never understood this either. When there is a custom DS/Event (allowEditorToParse == FALSE) the version number is exposed when you click on it.
allowEditorToParse == FALSE
Is that a deal breaker though? Perhaps events/datasources saved by Symphony could explicitly say Symphony 2.2.1 and if users want to use custom versioning they are free to do so.
ie. Cacheable Datasource 0.1, Union Datasource 0.2
In fact, in Union Datasource I am already using the extension's version as the Datasource version to aid in debugging for me.
The text at the moment for when allowEditorToParse returns false is 'VERSION released on DATE'.
'VERSION released on DATE'
How about 'Created by %s, at %s'?
'Created by %s, at %s'
Created by Symphony 2.2.1 at 12th June 2011 1pm
Created by Union Datasource at 12th June 2011 1pm
It's also interesting to note that the Datasource Editor is the only place where the version is shown, the Event Editor doesn't display the same information, it just outputs the description.
Check this commit, if noone objects, I think this can be closed.
No objections here. The only reason why it was there is like Nick mentioned, something to display when allowEditorToParse is set to FALSE. But as you pointed out, it's not even doing that on the event editor page anyway.
The above commit adds the same functionality to the Event Editor page.
Symphony will now save Datasources/Events with the version of Symphony 2.2.2.
Which then reads, Generated by Symphony 2.2.2 at 10 June 2011.
Generated by Symphony 2.2.2 at 10 June 2011
That means things like Members can overwrite the version to be Members [version] or Union Datasource [version] which should help debugging (although rare) and possibly upgrading (again rare)
This issue is closed.
Contact the team
Symphony • Open Source XSLT CMS