XML Importer
From XML to entries in an instant
Closed#2: (0.1.0) Selection fails when XML contains namespaces (e.g. Atom)
-
-
- nickdunn
- Comment #1
- 11 Jan 10, 3:56 am
-
-
- buzzomatic
- Comment #2
- 11 Jan 10, 11:10 am
Fixed in master. All I did was save a namespaces array and apply those namespaces to the xpath object that does the querying. Seems to work fine!
This issue is closed.
There is a bug XML elements are namespaced. For example:
This means that if I use the following for my Included Elements XPath:
Nothing will be found.
Dynamic XML DSs get around this by allowing the author to add any namespaces they required as Name/URI pairs. I think the XML Importer needs the same option. To include these namespaces the Dynamic DS ingeniously creates an XSLT stylesheet on the fly, appends the namespaces as processing instructions, and applies it against the XML that is grabbed.
I think XML Importer should do exactly the same. Perhaps its grabbing of XML should even create a Dynamic DS object in memory so that the code for obtaining an XML file, including namespaces, and returning just the XML required, all remains in Symphony’s core (datasource.dynamic_xml.php).
Might be less maintenance in the long run? And is much cooler :-)