DS Editor duplicator: filters should not be orderable
A for , submitted by nickdunn on 04 January 2010
Announcement
Symphony's issue tracker has been moved to Github.
Issues are displayed here for reference only and cannot be created or edited.
Browse
Closed#191: DS Editor duplicator: filters should not be orderable
This requires several changes.
If you simply remove orderable
config for the DS duplicator, things break:
$('#filters-duplicator').symphonyDuplicator(); $('#fields-duplicator').symphonyDuplicator({ orderable: true });
This is because each section’s field (hidden in the HTML) contains a ol#filters-duplicator
. When jQuery selects based on an ID, it only finds the first. This is an occasion when starting with valid HTML in the first place would have prevented a bug ;-)
By changing the 4 instance of filters-duplicator
in content.blueprintsdatasources.php to create class
attributes rather than id
attributes, and modifying the JS to use a CSS selector, things are back to normal:
$('.filters-duplicator').symphonyDuplicator(); $('#fields-duplicator').symphonyDuplicator({ orderable: true });
Would be worth someone else testing this thoroughly too.
This issue is closed.
This was fixed in previous versions but has snuck back in with the new duplicator in 2.0.7. The filters duplicator should not be orderable since filters have no order.